2 declare(strict_types = 1);
18 use PhpParser\NodeTraverser;
19 use PhpParser\NodeVisitor\NameResolver;
20 use PhpParser\ParserFactory;
22 use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
27 class MethodArgumentRequiredStaticMatcherTest
extends UnitTestCase
32 public function hitsFromFixtureAreFound()
34 $parser = (
new ParserFactory())->create(ParserFactory::PREFER_PHP7);
35 $fixtureFile = __DIR__ .
'/Fixtures/MethodArgumentRequiredStaticMatcherFixture.php';
36 $statements =
$parser->parse(file_get_contents($fixtureFile));
38 $traverser =
new NodeTraverser();
39 $traverser->addVisitor(
new NameResolver());
42 'TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addNavigationComponent' => [
43 'numberOfMandatoryArguments' => 3,
44 'maximumNumberOfArguments' => 3,
46 'Breaking-82899-MoreRestrictingChecksForAPIMethodsInExtensionManagementUtility.rst',
50 $subject =
new MethodArgumentRequiredStaticMatcher($configuration);
51 $traverser->addVisitor($subject);
52 $traverser->traverse($statements);
53 $expectedHitLineNumbers = [
58 $actualHitLineNumbers = [];
59 foreach ($subject->getMatches() as $hit) {
60 $actualHitLineNumbers[] = $hit[
'line'];
62 $this->assertEquals($expectedHitLineNumbers, $actualHitLineNumbers);
68 public function matchesReturnsExpectedRestFilesDataProvider(): array
71 'two rest candidates with same number of arguments' => [
74 'numberOfMandatoryArguments' => 1,
75 'maximumNumberOfArguments' => 1,
82 'numberOfMandatoryArguments' => 1,
83 'maximumNumberOfArguments' => 1,
91 $someVar::aMethod();',
103 'three candidates, first and second hits' => [
106 'numberOfMandatoryArguments' => 3,
107 'maximumNumberOfArguments' => 3,
113 'numberOfMandatoryArguments' => 3,
114 'maximumNumberOfArguments' => 3,
119 'FooBar::aMethod' => [
120 'numberOfMandatoryArguments' => 2,
121 'maximumNumberOfArguments' => 3,
128 $someVar::aMethod(\'foo\', \'bar\');',
138 'one candidate, does not hit, enough arguments given' => [
141 'numberOfMandatoryArguments' => 1,
142 'maximumNumberOfArguments' => 1,
149 $someVar::aMethod(\'foo\');',
152 'no match, method call using argument unpacking' => [
155 'numberOfMandatoryArguments' => 1,
156 'maximumNumberOfArguments' => 1,
163 $args = [\'arg1\', \'arg2\', \'arg3\'];
164 $someVar::aMethod(...$args);',
167 'double linked .rst file is returned only once' => [
170 'numberOfMandatoryArguments' => 1,
171 'maximumNumberOfArguments' => 1,
177 'numberOfMandatoryArguments' => 1,
178 'maximumNumberOfArguments' => 1,
185 $someVar::aMethod();',
204 public function matchesReturnsExpectedRestFiles(array $configuration,
string $phpCode, array $expected)
206 $parser = (
new ParserFactory())->create(ParserFactory::ONLY_PHP7);
207 $statements =
$parser->parse($phpCode);
209 $subject =
new MethodArgumentRequiredStaticMatcher($configuration);
211 $traverser =
new NodeTraverser();
212 $traverser->addVisitor($subject);
213 $traverser->traverse($statements);
215 $result = $subject->getMatches();
216 if (isset($expected[0], $result[0])) {
217 $this->assertEquals($expected[0][
'restFiles'], $result[0][
'restFiles']);
219 $this->assertEquals($expected, $result);