DatabaseIntegrityControllerTest.php

Go to the documentation of this file.

<?php
 
declare(strict_types=1);
 
/*
 * This file is part of the TYPO3 CMS project.
 *
 * It is free software; you can redistribute it and/or modify it under
 * the terms of the GNU General Public License, either version 2
 * of the License, or any later version.
 *
 * For the full copyright and license information, please read the
 * LICENSE.txt file that was distributed with this source code.
 *
 * The TYPO3 project - inspiring people to share!
 */
 
namespace ‪TYPO3\CMS\Lowlevel\Tests\Functional\Controller;
 
use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\Attributes\Test;
use ‪TYPO3\CMS\Backend\Routing\Router;
use ‪TYPO3\CMS\Backend\Routing\UriBuilder;
use ‪TYPO3\CMS\Backend\Template\ModuleTemplateFactory;
use ‪TYPO3\CMS\Core\Database\Platform\PlatformHelper;
use ‪TYPO3\CMS\Core\Http\ServerRequest;
use ‪TYPO3\CMS\Core\Imaging\Icon;
use ‪TYPO3\CMS\Core\Imaging\IconFactory;
use ‪TYPO3\CMS\Core\Localization\LanguageServiceFactory;
use ‪TYPO3\CMS\Core\Utility\GeneralUtility;
use ‪TYPO3\CMS\Lowlevel\Controller\DatabaseIntegrityController;
use TYPO3\TestingFramework\Core\Functional\FunctionalTestCase;
 
final class ‪DatabaseIntegrityControllerTest extends FunctionalTestCase
{
    protected array ‪$coreExtensionsToLoad = [
        'lowlevel',
    ];
 
    protected function ‪setUp(): void
    {
        parent::setUp();
        $this->importCSVDataSet(__DIR__ . '/../Fixtures/be_users.csv');
        $this->setUpBackendUser(1);
        ‪$GLOBALS['LANG'] = $this->get(LanguageServiceFactory::class)->create('default');
    }
 
    #[Test]
    public function ‪getTreeListReturnsIngoingIdIfDepthIsZero(): void
    {
        $id = 1;
        $depth = 0;
        $subject = $this->getAccessibleMock(DatabaseIntegrityController::class, null, [], '', false);
        $treeList = $subject->_call('getTreeList', $id, $depth);
        self::assertEquals($id, $treeList);
    }
 
    #[Test]
    public function ‪getTreeListReturnsIngoingIdIfIdIsZero(): void
    {
        $id = 0;
        $depth = 1;
        $subject = $this->getAccessibleMock(DatabaseIntegrityController::class, null, [], '', false);
        $treeList = $subject->_call('getTreeList', $id, $depth);
        self::assertEquals($id, $treeList);
    }
 
    #[Test]
    public function ‪getTreeListReturnsPositiveIngoingIdIfIdIsNegative(): void
    {
        $id = -1;
        $depth = 0;
        $subject = $this->getAccessibleMock(DatabaseIntegrityController::class, null, [], '', false);
        $treeList = $subject->_call('getTreeList', $id, $depth);
        self::assertEquals(1, $treeList);
    }
 
    #[Test]
    public function ‪getTreeListReturnsEmptyStringIfIdAndDepthAreZeroAndBeginDoesNotEqualZero(): void
    {
        $id = 0;
        $depth = 0;
        $begin = 1;
        $subject = $this->getAccessibleMock(DatabaseIntegrityController::class, null, [], '', false);
        $treeList = $subject->_call('getTreeList', $id, $depth, $begin);
        self::assertSame('', $treeList);
    }
 
    #[Test]
    public function ‪getTreeListReturnsIncomingIdIfNoSubPageRecordsOfThatIdExist(): void
    {
        $id = 1;
        $depth = 1;
        $subject = $this->getAccessibleMock(DatabaseIntegrityController::class, null, [], '', false);
        $treeList = $subject->_call('getTreeList', $id, $depth);
        self::assertEquals($id, $treeList);
    }
 
    #[Test]
    public function ‪getTreeListRespectsPermClauses(): void
    {
        $this->importCSVDataSet(__DIR__ . '/Fixtures/TestGetPageTreeStraightTreeSet.csv');
        $id = 1;
        $depth = 99;
        $subject = $this->getAccessibleMock(DatabaseIntegrityController::class, null, [], '', false);
        $treeList = $subject->_call('getTreeList', $id, $depth, 0, 'hidden=0');
        self::assertSame('1,2,3,4,5', $treeList);
    }
 
    public static function ‪dataForGetTreeListReturnsListOfIdsWithBeginSetToZero(): array
    {
        return [
            [
                1, // id
                1, // depth
                '1,2', // expectation
            ],
            [
                1,
                2,
                '1,2,3',
            ],
            [
                1,
                99,
                '1,2,3,4,5,6',
            ],
            [
                2,
                1,
                '2,3',
            ],
        ];
    }
 
    #[DataProvider('dataForGetTreeListReturnsListOfIdsWithBeginSetToZero')]
    #[Test]
    public function ‪getTreeListReturnsListOfIdsWithBeginSetToZero(int $id, int $depth, string $expectation): void
    {
        $this->importCSVDataSet(__DIR__ . '/Fixtures/TestGetPageTreeStraightTreeSet.csv');
        $subject = $this->getAccessibleMock(DatabaseIntegrityController::class, null, [], '', false);
        $treeList = $subject->_call('getTreeList', $id, $depth);
        self::assertSame($expectation, $treeList);
    }
 
    public static function ‪dataForGetTreeListReturnsListOfIdsWithBeginSetToMinusOne(): array
    {
        return [
            [
                1, // id
                1, // depth
                ',2', // expectation
            ],
            [
                1,
                2,
                ',2,3',
            ],
            [
                1,
                99,
                ',2,3,4,5,6',
            ],
            [
                2,
                1,
                ',3',
            ],
        ];
    }
 
    #[DataProvider('dataForGetTreeListReturnsListOfIdsWithBeginSetToMinusOne')]
    #[Test]
    public function ‪getTreeListReturnsListOfIdsWithBeginSetToMinusOne(int $id, int $depth, string $expectation): void
    {
        $this->importCSVDataSet(__DIR__ . '/Fixtures/TestGetPageTreeStraightTreeSet.csv');
        $subject = $this->getAccessibleMock(DatabaseIntegrityController::class, null, [], '', false);
        $treeList = $subject->_call('getTreeList', $id, $depth, -1);
        self::assertSame($expectation, $treeList);
    }
 
    #[Test]
    public function ‪getTreeListReturnsListOfPageIdsOfABranchedTreeWithBeginSetToZero(): void
    {
        $id = 1;
        $depth = 3;
        $this->importCSVDataSet(__DIR__ . '/Fixtures/TestGetPageTreeBranchedTreeSet.csv');
        $subject = $this->getAccessibleMock(DatabaseIntegrityController::class, null, [], '', false);
        $treeList = $subject->_call('getTreeList', $id, $depth);
        self::assertSame('1,2,3,4,5', $treeList);
    }
 
    #[Test]
    public function ‪getTreeListReturnsListOfPageIdsOfABranchedTreeWithBeginSetToOne(): void
    {
        $id = 1;
        $depth = 3;
        $begin = 1;
        $this->importCSVDataSet(__DIR__ . '/Fixtures/TestGetPageTreeBranchedTreeSet.csv');
        $subject = $this->getAccessibleMock(DatabaseIntegrityController::class, null, [], '', false);
        $treeList = $subject->_call('getTreeList', $id, $depth, $begin);
        self::assertSame('2,3,4,5', $treeList);
    }
 
    #[Test]
    public function ‪getTreeListReturnsListOfPageIdsOfABranchedTreeWithBeginSetToTwo(): void
    {
        $id = 1;
        $depth = 3;
        $begin = 2;
        $this->importCSVDataSet(__DIR__ . '/Fixtures/TestGetPageTreeBranchedTreeSet.csv');
        $subject = $this->getAccessibleMock(DatabaseIntegrityController::class, null, [], '', false);
        $treeList = $subject->_call('getTreeList', $id, $depth, $begin);
        self::assertSame('3,5', $treeList);
    }
 
    public static function ‪getQueryWithIdOrDateDataProvider(): array
    {
        return [
            'pid 5134' => [
                5134,
                null,
                "pid = '5134'",
            ],
            'unix timestamp' => [
                1522863047,
                null,
                "pid = '1522863047'",
            ],
            'pid 5134 as string' => [
                '5134',
                null,
                "pid = '5134'",
            ],
            'unix timestamp as string' => [
                '1522863047',
                null,
                "pid = '1522863047'",
            ],
            'ISO 8601 date string' => [
                '2018-04-04T17:30:47Z',
                null,
                "pid = '1522863047'",
            ],
            'pid 5134 and second input value 5135' => [
                5134,
                5135,
                'pid >= 5134 AND pid <= 5135',
                'comparison' => 100,
            ],
            'ISO 8601 date string as first and second input' => [
                '2018-04-04T17:30:47Z',
                '2018-04-04T17:30:48Z',
                'pid >= 1522863047 AND pid <= 1522863048',
                'comparison' => 100,
            ],
        ];
    }
 
    #[DataProvider('getQueryWithIdOrDateDataProvider')]
    #[Test]
    public function ‪getQueryWithIdOrDate(mixed $inputValue, mixed $inputValue1, string $expected, int $comparison = 64): void
    {
        ‪$GLOBALS['TCA'] = [
            'aTable' => [
                'columns' => [],
            ],
        ];
        $inputConf = [
            [
                'operator' => '',
                'type' => 'FIELD_pid',
                'comparison' => $comparison,
                'inputValue' => $inputValue,
                'inputValue1' => $inputValue1,
            ],
        ];
        $subject = $this->getAccessibleMock(DatabaseIntegrityController::class, null, [], '', false);
        $subject->_call('init', 'queryConfig', 'aTable');
        self::assertSame($expected, trim($subject->_call('getQuery', $inputConf), "\n\r"));
    }
 
    public static function ‪arbitraryDataIsEscapedDataProvider(): array
    {
        $dataSet = [];
        $injectors = [
            // INJ'ECT
            'INJ%quoteCharacter%ECT',
            // INJ '--
            // ' ECT
            'INJ %quoteCharacter%%commentStart% %commentEnd%%quoteCharacter% ECT',
        ];
        $subjectReflection = new \ReflectionClass(DatabaseIntegrityController::class);
        $comparisons = array_keys($subjectReflection->getProperty('compSQL')->getDefaultValue());
        foreach ($injectors as $injector) {
            foreach ($comparisons as $comparison) {
                $dataSet[] = [
                    $injector,
                    [
                        'queryTable' => 'tt_content',
                        'queryFields' => 'uid,' . $injector,
                        'queryGroup' => $injector,
                        'queryOrder' => $injector,
                        'queryLimit' => $injector,
                        'queryConfig' => [
                            [
                                'operator' => $injector,
                                'type' => 'FIELD_category_field', // falls back to CType (first field)
                                'comparison' => $comparison,
                                'inputValue' => $injector,
                            ],
                            [
                                'operator' => $injector,
                                'type' => 'FIELD_category_field',
                                'comparison' => $comparison,
                                'inputValue' => $injector,
                            ],
                        ],
                    ],
                ];
            }
        }
        return $dataSet;
    }
 
    #[DataProvider('arbitraryDataIsEscapedDataProvider')]
    #[Test]
    public function ‪arbitraryDataIsEscaped(string $injector, array $settings): void
    {
        $replacements = [
            '%quoteCharacter%' => "'",
            '%commentStart%' => '--',
            '%commentEnd%' => "\n",
        ];
        $injector = str_replace(array_keys($replacements), $replacements, $injector);
        $settings = $this->‪prepareSettings($settings, $replacements);
        $settings['queryConfig'] = serialize($settings['queryConfig']);
 
        $iconMock = $this->getMockBuilder(Icon::class)->getMock();
        $iconMock->method('render')->willReturn('');
 
        $iconFactoryMock = $this->getMockBuilder(IconFactory::class)->disableOriginalConstructor()->getMock();
        $iconFactoryMock->method('getIcon')->willReturn($iconMock);
 
        $route = GeneralUtility::makeInstance(Router::class)->getRoute('system_dbint');
        $route->setOption('_identifier', 'system_dbint');
        $request = (new ‪ServerRequest())->withAttribute('route', $route);
 
        $subject = $this->getAccessibleMock(DatabaseIntegrityController::class, null, [
            $iconFactoryMock,
            GeneralUtility::makeInstance(UriBuilder::class),
            GeneralUtility::makeInstance(ModuleTemplateFactory::class),
            GeneralUtility::makeInstance(PlatformHelper::class),
        ]);
        $subject->_call('init', 'queryConfig', $settings['queryTable']);
        $subject->_call('makeSelectorTable', $settings, $request);
        $subject->_set('enablePrefix', true);
 
        $queryString = $subject->_call('getQuery', $subject->_get('queryConfig'));
        $query = $subject->_call('getSelectQuery', $queryString);
 
        self::assertStringNotContainsString($injector, $query);
    }
 
    private function ‪prepareSettings(array $settings, array $replacements): array
    {
        foreach ($settings as $settingKey => &$settingValue) {
            if (is_string($settingValue)) {
                $settingValue = str_replace(array_keys($replacements), $replacements, $settingValue);
            }
            if (is_array($settingValue)) {
                $settingValue = $this->‪prepareSettings($settingValue, $replacements);
            }
        }
        return $settings;
    }
}