Member TYPO3\CMS\Extbase\Configuration\ConfigurationManager::$concreteConfigurationManager

‪: Make nullable and private(?) in v13.

Member TYPO3\CMS\Core\Tests\Functional\DataScenarios\Regular\WorkspacesModify\ActionTest::changeContentSortingAndDeleteMovedRecord ()

‪: Publish and PublishAll for this are missing - TF throws an exception on publish due to deleted state

Member TYPO3\CMS\Core\Tests\Functional\SiteHandling\SiteBasedTestTrait::applyInstructions (InternalRequest $request, AbstractInstruction ... $instructions)

‪Instruction handling should be part of Testing Framework (multiple instructions per identifier, merge in interface)

Member TYPO3\CMS\Core\Tests\Unit\Database\Query\QueryBuilderTest::deleteQuotesIdentifierAndDelegatesToConcreteQueryBuilder ()

‪: Test with alias

Member TYPO3\CMS\Core\Tests\Unit\Database\Query\QueryBuilderTest::updateQuotesIdentifierAndDelegatesToConcreteQueryBuilder ()

‪: Test with alias

Member TYPO3\CMS\Core\Tests\Unit\Database\Query\QueryBuilderTest::fromQuotesIdentifierAndDelegatesToConcreteQueryBuilder ()

‪: Test with alias

Member TYPO3\CMS\Core\Tests\Unit\LinkHandling\EmailLinkHandlerTest::resolveReturnsSplitParameters ($input, $expected, $finalString)

‪Defining the method parameter types results in test bench errors

Member TYPO3\CMS\Core\Tests\Unit\LinkHandling\EmailLinkHandlerTest::splitParametersToUnifiedIdentifier ($input, $parameters, $expected)

‪Defining the method parameter types results in test bench errors

Member TYPO3\CMS\Core\Tests\Unit\Pagination\SimplePaginationTest::$paginator

‪Specifying the type in the declaration results in a test bench error

Class TYPO3\CMS\Core\Tests\Unit\Resource\Index\ExtractorRegistryTest

‪: Use fixture classes instead of mocks for the extractors to simplify the setup.

Class TYPO3\CMS\Core\Tests\Unit\Utility\ArrayUtilityTest

‪When further defining the method parameter types test bench errors occur

Member TYPO3\CMS\Core\Tests\Unit\Utility\CommandUtilityTest::getConfiguredApps ($globalsBinSetup, $expected)

‪When specifying parameter types test bench errors occur

Class TYPO3\CMS\Core\Tests\Unit\Utility\PathUtilityTest

‪Defining the method parameter types further leads to test bench errors

Member TYPO3\CMS\Extbase\Configuration\BackendConfigurationManager::$request

‪: In CLI context, BE configuration manager might be triggered without request. See comment on this in ConfigurationManager.

Member TYPO3\CMS\Core\Tests\Functional\DataScenarios\Regular\AbstractActionTestCase::movePageLocalizedInLiveWorkspaceDeletedToDifferentPageTwice ()

‪The "deleted" t3ver_state=2 record is turned into a move placeholder so the "marked for delete" information is lost.

Member TYPO3\CMS\Extbase\Configuration\ConfigurationManagerInterface::setConfiguration (array $configuration=[])

‪: It may be possible to remove this in v13?!

Member TYPO3\CMS\Extbase\Configuration\FrontendConfigurationManager::$request

‪: In v13, this shouldn't be nullable, FE context always has a request.

Member TYPO3\CMS\Extbase\DomainObject\AbstractDomainObject::int< 1, $uid;protected int|null $_localizedUid=null;protected int|null $_languageUid=null;protected int|null $_versionedUid=null;protected int< 0, $pid;private bool $_isClone=false;private array $_cleanProperties=[];public int< 1, function getUid():int|null { if($this->uid !==null) { return(int) $this->uid;} return null;} public function setPid(int $pid):void { $this->pid=$pid;} public int< 0, function getPid():int|null { if($this->pid===null) { return null;} return(int) $this->pid;} public function _setProperty(string $propertyName, mixed $propertyValue):bool { if($this->_hasProperty($propertyName)) { $this->

‪introduce type declarations in 13.0 (possibly breaking)

Member TYPO3\CMS\Extbase\Error\Result::recurseThroughResult (array $pathSegments)

‪: consider making this method protected as it will and should not be called from an outside scope

Member TYPO3\CMS\Extbase\Mvc\Dispatcher::buildRequestFromCurrentRequestAndForwardResponse (RequestInterface $currentRequest, ForwardResponse $forwardResponse)

‪: make this a private method again as soon as the tests, that fake the dispatching of requests, are refactored.

Member TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder::convertTransientObjectToArray (DomainObjectInterface $object)

‪Refactor this into convertDomainObjectsToIdentityArrays()

Member TYPO3\CMS\Extbase\Persistence\Generic\Qom\Comparison::$operand2

‪Type this as mixed in v13.

Member TYPO3\CMS\Extbase\Persistence\Generic\Qom\ComparisonInterface::getOperand2 ()

‪Type this as mixed in v13.

Class TYPO3\CMS\Extbase\Persistence\Generic\Query

‪v12: Candidate to declare final - Can be decorated or standalone class implementing the interface @template T of object

Member TYPO3\CMS\Extbase\Persistence\Generic\Query::getSelectorName ()

‪This has to be checked at another place

Class TYPO3\CMS\Extbase\Persistence\Generic\QueryResult

‪v12: Candidate to declare final - Can be decorated or standalone class implementing the interface @template TValue of object

Member TYPO3\CMS\Extbase\Persistence\Generic\Storage\BackendInterface::getUidOfAlreadyPersistedValueObject (AbstractValueObject $object)

‪this is the last monster in this persistence series. refactor!

Member TYPO3\CMS\Extbase\Property\TypeConverter\AbstractTypeConverter::getTargetTypeForSource ($source, string $originalTargetType, PropertyMappingConfigurationInterface $configuration=null)

‪The concept of this method is flawed because it enables the override of the target type depending on the structure of the source. So, technically we no longer convert type A to B but source of type A with structure X to type B defined by X. This makes a type converter non-deterministic.

Member TYPO3\CMS\Core\Tests\Functional\DataScenarios\IrreForeignFieldNonWs\WorkspacesModify\ActionTest::copyParentContentToDifferentPage ()

‪: Leads to issues with sys_refindex which does not adapt sorting field for live changes.

Member TYPO3\CMS\Core\Routing\Route::getArguments ()

‪'_arguments' are added implicitly, make it explicit in enhancers

Member TYPO3\CMS\Core\Tree\TableConfiguration\AbstractTableConfigurationTreeDataProvider::$availableItems

‪: This is a hack to speed up category tree calculation. See the comments in TcaCategory and AbstractItemProvider FormEngine classes.

Member TYPO3\CMS\Core\TypoScript\IncludeTree\SysTemplateRepository::getSysTemplateRowsByRootline (array $rootline, ?ServerRequestInterface $request=null)

‪: It's potentially possible to get rid of this method in the frontend by joining sys_template into the Page rootline resolving as soon as it uses a CTE: This would save one query in all FE requests, even for fully-cached page requests.

Member TYPO3\CMS\Core\TypoScript\TypoScriptService::convertTypoScriptArrayToPlainArray ($value)

‪: Usages should be removed mid-term to work on the TypoScript object tree directly.

Member TYPO3\CMS\Core\TypoScript\TypoScriptService::convertPlainArrayToTypoScriptArray (array $plainArray)

‪: Usages should be removed mid-term to work on the TypoScript object tree directly.

Member TYPO3\CMS\Core\TypoScript\TypoScriptService::explodeConfigurationForOptionSplit (array $originalConfiguration, int $splitCount)

‪: This method is a sign of bad abstraction. It should be modelled differently and located elsewhere.

Member TYPO3\CMS\Core\Utility\ArrayUtility::flatten (array $array, string $prefix='', bool $keepDots=false)

: The current implementation isn't a generic array flatten method, but tailored for TypoScript flattening

: It should be deprecated and removed and the required specialities should be put under the domain of TypoScript parsing

Member TYPO3\CMS\Core\Utility\File\BasicFileUtility::sanitizeFolderPath ($theDir)

‪: should go into the LocalDriver in a protected way (not important to the outside world)

Member TYPO3\CMS\Core\Utility\File\BasicFileUtility::getUniqueName ($theFile, $theDest, $dontCheckForUnique=false)

‪: should go into the LocalDriver in a protected way (not important to the outside world)

Member TYPO3\CMS\Core\Tests\Acceptance\Application\FormEngine\ElementsBasicInputRangeCest::simpleRangeAndMd5FieldsDataProvider ()

‪this one probably broke with the type="number" patch 'label' => 'number_3', 'inputValue' => 'Kasper TYPO3', 'expectedValue' => '0', 'expectedInternalValue' => '0', 'expectedValueAfterSave' => '0', 'comment' => '', 'tab' => 'number', ],

Member TYPO3\CMS\Core\Tests\Functional\DataScenarios\IrreCsv\AbstractActionTestCase::copyParentContentToLanguageWithAllChildren ()

‪Test missing in workspaces!

Class TYPO3\CMS\Core\Tests\Functional\DataScenarios\IrreForeignFieldNonWs\WorkspacesModify\ActionTest

‪: All these workspace tests on not-ws aware hotel, child and price tables are funny. Even though 'live_edit' is true, editing for instance a ws-aware pages or tt_content table and deleting / adding a hotel child raises DH warnings "Record could not be created in this workspace" or "Versioning is not supported for this table". This is technically fine. However, having an inline relation from a ws-aware table to a non-ws aware table (even with live_edit=1) and then editing relations in a workspace is logically inconsistent. We may want to scan for these scenarios in TCA and notify / deprecate it by hinting integrators on this problematic situation when ext:workspaces is loaded?! Avoiding this would relax quite a few scenarios here. Note sys_file is a special scenario here as well (not covered by the tests below, though). In the end, all these cases below need a review and thoughts. For now, we're skipping "WorkspaceDiscard", "WorkspacePublish" and "WorkspacePublishAll" tests, since "WorkspaceModify" already show enough inconsistencies.

Member TYPO3\CMS\Core\Tests\Functional\DataScenarios\IrreForeignFieldNonWs\WorkspacesModify\ActionTest::copyParentContent ()

‪: Leads to issues with sys_refindex which does not adapt sorting field for live changes.

Member TYPO3\CMS\Extbase\Property\TypeConverter\AbstractTypeConverter::getSourceChildPropertiesToBeConverted ($source)

‪this method is only used for converter sources that have children (i.e. objects). Introduce another ChildPropertyAwareTypeConverterInterface and drop this method from the main interface

Member TYPO3\CMS\Core\Tests\Functional\DataScenarios\IrreForeignFieldNonWs\WorkspacesModify\ActionTest::moveParentContentToDifferentPage ()

‪: "Trying to access array offset on value of type bool" - workspaces/Classes/Hook/DataHandlerHook.php:366

Member TYPO3\CMS\Core\Tests\Functional\DataScenarios\IrreForeignFieldNonWs\WorkspacesModify\ActionTest::moveParentContentToDifferentPageTwice ()

‪: "Trying to access array offset on value of type bool" - workspaces/Classes/Hook/DataHandlerHook.php:366

Member TYPO3\CMS\Core\Tests\Functional\DataScenarios\IrreForeignFieldNonWs\WorkspacesModify\ActionTest::moveParentContentToDifferentPageAndChangeSorting ()

‪: "Trying to access array offset on value of type bool" - workspaces/Classes/Hook/DataHandlerHook.php:366

Member TYPO3\CMS\Core\Tests\Functional\DataScenarios\IrreForeignFieldNonWs\WorkspacesModify\ActionTest::copyPage ()

‪: Leads to issues with sys_refindex which does not adapt sorting field for live changes.

Member TYPO3\CMS\Core\Tests\Functional\DataScenarios\IrreForeignFieldNonWs\WorkspacesModify\ActionTest::copyPageWithHotelBeforeParentContent ()

‪: Leads to issues with sys_refindex which does not adapt sorting field for live changes.

Member TYPO3\CMS\Core\Tests\Functional\DataScenarios\IrreForeignFieldNonWs\WorkspacesModify\ActionTest::createAndCopyParentContentWithHotelAndOfferChildren ()

‪: Weird - this may / should localize the live record? What happens here?

Member TYPO3\CMS\Core\Tests\Functional\DataScenarios\IrreForeignFieldNonWs\WorkspacesModify\ActionTest::modifyParentAndChangeHotelChildrenSorting ()

‪: Leads to issues with sys_refindex which does not adapt sorting field for live changes.

Member TYPO3\CMS\Core\Tests\Functional\DataScenarios\IrreForeignFieldNonWs\WorkspacesModify\ActionTest::modifyAndDiscardAndModifyParentWithHotelChild ()

‪: This reveals another core bug "Undefined array key "t3ver_state"" in ElementEntityProcessor.php

Member TYPO3\CMS\Core\Tests\Functional\DataScenarios\IrreForeignFieldNonWs\WorkspacesModify\ActionTest::inlineLocalizeSynchronizeLocalizeMissing ()

‪: Weird - this may / should localize the live record? What happens here?

Member TYPO3\CMS\Core\Tests\Functional\DataScenarios\ManyToMany\AbstractActionTestCase::copyCategoryToLanguageOfRelation ()

‪: This action does not copy the relations with it (at least in workspaces), and should be re-evaluated

Member TYPO3\CMS\Core\Tests\Functional\DataScenarios\ManyToMany\WorkspacesDiscard\ActionTest::copyCategoryToLanguageOfRelation ()

‪: this is a faulty test, because the category should be discarded

Member TYPO3\CMS\Core\Tests\Functional\DataScenarios\ManyToMany\WorkspacesModify\ActionTest::localizeContentOfRelationAndAddCategoryWithLanguageSynchronization ()

‪: this test is faulty as it adds a lot of entries

Member TYPO3\CMS\Reactions\Form\Element\FieldMapElement::render ()

‪This is not how a field label should be resolved

Member TYPO3\CMS\Frontend\Tests\Functional\SiteHandling\MountPointTest::mountPointPagesShowContentAsConfigured (string $uri, string $expected)

‪: revisit the "mount_pid_ol=1" redirect, there is some truth to it, but still would remove the context, which does not make sense. Should be revisited. See test above as well.

Member TYPO3\CMS\Frontend\Tests\Functional\SiteHandling\SiteRequestTest::restrictedPageSendsForbiddenResponseWithUnauthorizedVisitorWithHavingPageErrorHandling (string $uri, int $frontendUserId)

‪Response body cannot be asserted since PageContentErrorHandler::handlePageError executes request via HTTP (not internally)

Member TYPO3\CMS\Frontend\Tests\Functional\SiteHandling\SiteRequestTest::restrictedPageWithParentSysFolderSendsForbiddenResponseWithUnauthorizedVisitorWithHavingPageErrorHandling (string $uri, int $frontendUserId)

‪Response body cannot be asserted since PageContentErrorHandler::handlePageError executes request via HTTP (not internally)

Member TYPO3\CMS\Frontend\Tests\Functional\SiteHandling\SiteRequestTest::pageRequestSendsNotFoundResponseWithInvalidCacheHashWithHavingPageErrorHandling (string $uri)

‪Response body cannot be asserted since PageContentErrorHandler::handlePageError executes request via HTTP (not internally)

Class TYPO3\CMS\Frontend\Tests\Unit\Http\RequestHandlerTest

‪: It looks as if these unit tests should be turned into functional tests

Member TYPO3\CMS\IndexedSearch\Controller\SearchController::$domainRecords

‪remove sys_domain records

Member TYPO3\CMS\IndexedSearch\Controller\SearchController::makeRating ($row)

‪can this be a ViewHelper?

Member TYPO3\CMS\IndexedSearch\Controller\SearchController::makeDescription ($row, $noMarkup=false, $length=180)

‪overwork this

Member TYPO3\CMS\IndexedSearch\Controller\SearchController::preparePageLink (int $pageUid, array $row, array $urlParameters)

‪make use of the UriBuilder

Member TYPO3\CMS\Install\Controller\UpgradeController::upgradeWizardsBlockingDatabaseCharsetFixAction ()

‪This must be reviewed and decided if we can remove this, move to reports module or if we have other issues with charset on connection and database, or if we need to escalate this down to field level.

Member TYPO3\CMS\Install\Controller\UpgradeController::upgradeWizardsBlockingDatabaseCharsetTestAction ()

‪This must be reviewed and decided if we can remove this, move to reports module or if we have other issues with charset on connection and database, or if we need to escalate this down to field level.

Member TYPO3\CMS\Install\Service\CoreUpdateService::setDownloadTargetPath ($downloadTargetPath)

‪move this to folder structure

Class TYPO3\CMS\Lowlevel\Command\MissingRelationsCommand

‪: The entire logic smells fishy and needs a major overhaul.

Class TYPO3\CMS\Frontend\Tests\Functional\SiteHandling\MountPointTest

add Tests for having a PageFolder as mounted page (e.g. id 10000)

Add tests for multilingual setups

Add tests with various TypoScript settings activated

Class TYPO3\CMS\Reactions\Pagination\DemandedArrayPaginator

‪should be replaced with the regular ArrayPaginator

Member TYPO3\CMS\Recycler\Controller\RecyclerAjaxController::getUserWhoDeleted (string $table, int $uid)

‪: move this to RecordHistory class

Member TYPO3\CMS\Redirects\Hooks\DataHandlerCacheFlushingHook::rebuildRedirectCacheIfNecessary (array $parameters, DataHandler $dataHandler)

‪This hook is called for each record which needs to clear cache, which means this gets called for other records than sys_redirects, but also for each sys_redirect record which has been modified with this DataHandler call. Even if we can narrow down to rebuild only for specific source_hosts, this still means that we eventually rebuild the "same" cache multiple times. Find a better way to aggregate them and rebuild only once at the end.

Member TYPO3\CMS\Redirects\Service\RedirectService::bootFrontendController (SiteInterface $site, array $queryParams, ServerRequestInterface $originalRequest)

‪: This messes quite a bit with dependencies here. RedirectService is called by an early middleware before TSFE has been set up at all. The code thus has to hop through various loops later middlewares would usually do. The overall scenario of needing a partially set up TSFE for target redirect calculation is quite unfortunate here and should be sorted out differently by further refactoring the link building and reducing TSFE dependencies.

Member TYPO3\CMS\Redirects\Service\RedirectService::cleanupTSFE ()

‪: Needs to vanish. The existence of this method is a side-effect of the technical debt that a TSFE has to be set up for link generation, see the comment on bootFrontendController() for more details.

Class TYPO3\CMS\Redirects\Tests\Functional\Service\SlugServiceTest

‪Tests in this TestCase simulates what happens in the corresponding DataHandlerSlugUpdateHook, mainly which is executed in which order. This is somehow clumsy. Either cover proper DataHandler hook execution with additional tests avoiding the simulation and testing SlugService in indirect way - or refactor them here.

Member TYPO3\CMS\Scheduler\Controller\SchedulerModuleController::stopTask (ModuleTemplate $view, int $taskUid)

‪find a way to really kill the running task.

Member TYPO3\CMS\Scheduler\Scheduler::cleanExecutionArrays ()

‪find a way to actually kill the job

Class TYPO3\CMS\Webhooks\Pagination\DemandedArrayPaginator

‪should be replaced with the regular ArrayPaginator

Class TYPO3\CMS\Workspaces\Controller\AjaxDispatcher

‪: The entire workspace modul ajax routing is a mess and needs a rewrite.

Member TYPO3\CMS\Workspaces\Controller\Remote\ActionHandler::publishSingleRecord ($table, $t3ver_oid, $orig_uid)

‪What about reporting errors back to the interface? /olly/

Member TYPO3\CMS\Workspaces\Controller\Remote\ActionHandler::deleteSingleRecord ($table, $uid)

‪What about reporting errors back to the interface? /olly/

Member TYPO3\CMS\Fluid\ViewHelpers\Form\ValidationResultsViewHelper::renderStatic (array $arguments, \Closure $renderChildrenClosure, RenderingContextInterface $renderingContext)

‪: Really mixed here, not string?

Member TYPO3\CMS\Extbase\Property\TypeConverter\AbstractTypeConverter::getTypeOfChildProperty (string $targetType, string $propertyName, PropertyMappingConfigurationInterface $configuration)

‪this method is only used for converter sources that have children (i.e. objects). Introduce another ChildPropertyAwareTypeConverterInterface and drop this method from the main interface

Member TYPO3\CMS\Extbase\Reflection\ObjectAccess::enableExceptionOnInvalidIndex () -> getPropertyAccessor()

‪What to do with ArrayAccess

Member TYPO3\CMS\Extbase\Security\Cryptography\HashService::appendHmac (string $string)

‪Mark as API once it is more stable

Member TYPO3\CMS\Extbase\Security\Cryptography\HashService::validateAndStripHmac (string $string)

‪Mark as API once it is more stable

Member TYPO3\CMS\Extbase\Validation\Validator\AbstractCompositeValidator::$validatedInstancesContainer

‪: Properties {

Member TYPO3\CMS\Extbase\Tests\Functional\Mvc\Controller\ActionControllerArgumentTest::validationErrorReturnsToForwardedPreviousAction (string $forwardTargetAction, array $forwardTargetArguments, string $validateAction, array $expectations)

‪: It might be better if these tests would executeFrontendSubRequest() to setup less stuff on their own?!

Member TYPO3\CMS\Extbase\Tests\Unit\Validation\Validator\Fixture\AbstractCompositeValidatorClass::$supportedOptions

‪Declare the property type in the parent class

Member TYPO3\CMS\Extbase\Tests\Unit\Validation\Validator\Fixture\AbstractValidatorClass::$supportedOptions

‪Declare the property type in the parent class

Member TYPO3\CMS\Extensionmanager\Utility\DependencyUtility::checkExtensionDependency (Dependency $dependency)

‪handle exceptions / markForUpload

Member TYPO3\CMS\Fluid\ViewHelpers\Be\AbstractBackendViewHelper::getModuleTemplate ()

‪: deprecate. This should be obsolete with the new ModuleTemplate view strategy.

Class TYPO3\CMS\Fluid\ViewHelpers\Be\PageInfoViewHelper

‪: Candidate to deprecate? The page info is typically displayed in doc header, done by ModuleTemplate in controllers.

Class TYPO3\CMS\Fluid\ViewHelpers\Be\PagePathViewHelper

‪: Candidate to deprecate? The page info is typically displayed in doc header, done by ModuleTemplate in controllers.

Member TYPO3\CMS\Fluid\ViewHelpers\Form\SelectViewHelper::getOptionValueScalar ($valueElement)

‪: Does not always return string ...

Member TYPO3\CMS\Core\Resource\ResourceStorage::getRootLevelFolder (bool $respectFileMounts=true)

‪: this is a bad method design, because the calling code can never fetch all filemounts nor traverse them.

Member TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::renderHiddenReferrerFields ()

‪filter out referrer information that is equal to the target (e.g. same packageKey)

Member TYPO3\CMS\Form\Controller\FormEditorController::transformFormDefinitionForFormEditor (array $formDefinition)

‪move this to FormDefinitionConversionService

Class TYPO3\CMS\Form\Domain\Model\FormDefinition

‪: Declare final in v12

Class TYPO3\CMS\Form\Domain\Runtime\FormRuntime

‪: Declare final in v12

Member TYPO3\CMS\Form\Domain\Runtime\FormRuntime::initializeFormSessionFromRequest ()

‪FormRuntime::$formSession is still vulnerable to session fixation unless a real cookie-based process is used

Member TYPO3\CMS\Form\Mvc\Property\TypeConverter\FormDefinitionArrayConverter::filterEmptyArrays (array $array)

‪ArrayUtility?

Member TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer::mergeTSRef (array $typoScriptArray, string $propertyName)

‪: It would be better if this method would get the setup object tree to resolve a ReferenceChildNode only once per node. This would however mean the object tree is moved around in the entire rendering chain, which is quite hard to achieve.

Member TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer::getRequest ()

‪: This getRequest() is still a bit messy. Underling code depends on both, a ContentObjectRenderer instance and a request, but the API currently only passes one or the other. For instance Extbase and Fluid only pass the Request, DataProcessors only a ContentObjectRenderer. This is why getRequest() is currently public here. A potential refactoring could:

‪Create interfaces to pass both where needed (or pass a combined context object)
‪Deprecate access to getRequest() here afterwards A circular dependency that the instance of ContentObjectRenderer holds a request with the instance of itself as attribute must be avoided. This is currently achieved by adding a new request with $this->request->withAttribute('currentContentObject', $cObj) in code that needs it, but this new request is NOT passed back into the ContentObjectRenderer instance.

Member TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController::checkRootlineForIncludeSection ()

Find a better name, i.e. checkVisibilityByRootLine

Invert boolean return value. Return true if visible.

Member TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController::getFromCache (ServerRequestInterface $request)

‪: This method is typically called by PrepareTypoScriptFrontendRendering middleware. However, the RedirectService of (earlier) ext:redirects RedirectHandler middleware calls this as well. We may want to put this code into some helper class, reduce class state as much as possible and carry really needed state as request attributes around?!

Member TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController::getBackendUser ()

‪: Add PHP return type declaration and ensure, that classes using TSFE in BE/CLI context always instantiate a FrontendBackendUserAuthentication object in $GLOBALS['BE_USER'].

Class TYPO3\CMS\Frontend\Resource\FileCollector

‪The file collector is used for intermediate collection in scoped places. Therefore, the collector can't be shared. Evaluate if the collector can be build scope aware and made sharable again.

Class TYPO3\CMS\Core\Database\Platform\PostgreSQL94Platform

‪Remove this class with doctrine/dbal:4.0 upgrade due to raised minimal supported PostgreSQL version.

Member TYPO3\CMS\Core\Composer\PackageArtifactBuilder::setTitleFromExtEmConf (Package $package)

‪deprecate or remove in TYPO3 v12

Member TYPO3\CMS\Core\Composer\PackageArtifactBuilder::handleRootPackage (PackageInterface $rootPackage, string $extensionKey)

‪: remove this method in TYPO3 v12

Class TYPO3\CMS\Core\Configuration\Richtext

‪When I grow up, I want to become a data provider

Member TYPO3\CMS\Core\Configuration\SiteConfiguration::getSiteSettings (string $siteIdentifier, array $siteConfiguration)

‪This method resolves placeholders during the loading, which is okay as this is only used in context where the replacement is needed. However, this may change in the future, for example if loading is needed for implementing a GUI for the settings - which should either get a dedicated method or a flag to control if placeholder should be resolved during yaml file loading or not. The SiteConfiguration save action currently avoid calling this method.

Member TYPO3\CMS\Core\Configuration\SiteConfiguration::write (string $siteIdentifier, array $configuration, bool $protectPlaceholders=false)

‪enforce $protectPlaceholders with TYPO3 v13.0

Member TYPO3\CMS\Core\Configuration\Tca\TcaPreparation::prepareFileExtensions (mixed $fileExtensions)

‪Does not need to be static, once FlexFormTools calls configureFileReferences() directly

Class TYPO3\CMS\Core\Console\CommandNameAlreadyInUseException

‪: deprecate

Member TYPO3\CMS\Core\Context\SecurityAspect::provideNonce ()

‪this is a "comfort function", might be dropped

Member TYPO3\CMS\Core\Core\Bootstrap::loadExtTables (bool $allowCaching=true, FrontendInterface $coreCache=null)

‪: It would be better to remove this method and use the factory directly. Needs a pre-patch in testing-framework.

Class TYPO3\CMS\Core\Database\Platform\MariaDB1027Platform

‪Remove this class with doctrine/dbal:4.0 upgrade, due to the raised minimal supported MariaDB version.

Class TYPO3\CMS\Core\Database\Platform\MariaDB1043Platform

‪doctrine/dbal:4.0 will replace MariaDBPlatform with the MariaDB1043Platform and drop the concrete class due to raised supported minimum MariaDB version. Remove this extended class with doctrine/dbal:4.0 upgrade.

Class TYPO3\CMS\Core\Database\Platform\MySQL57Platform

‪doctrine/dbal:4.0 will replace MySQLPlatform with the MySQL57Platform and drop the concrete class. Remove this extended class with doctrine/dbal:4.0 upgrade.

Class TYPO3\CMS\Core\Database\Platform\PostgreSQL100Platform

‪doctrine/dbal:4.0 will replace PostgreSQLPlatform with the PostgreSQL100Platform and drop the concrete class due to raised supported minimum PostgreSQL version. Remove this class with doctrine/dbal:4.0 upgrade.

Class TYPO3\CMS\Core\Cache\Frontend\NullFrontend

‪: Instead a factory class should be introduced that replaces this class and \TYPO3\CMS\Core\Core\Bootstrap::createCache

Member TYPO3\CMS\Core\Database\RelationHandler::readMM ($tableName, $uid, $mmOppositeTable)

‪: The source record is not checked for correct workspace. Say there is a category 5 in workspace 1. setWorkspace(0) is called, after that readMM('sys_category_record_mm', 5 ...). readMM will still return the list of records connected to this workspace 1 item, even though workspace 0 has been set.

Member TYPO3\CMS\Core\Database\RelationHandler::purgeItemArray ($workspaceId=null)

‪: It should be possible to drop all three 'purge' methods by using a clever join within readMM - that sounds doable now with pid -1 and ws-pair records being gone since v11. It would resolve this indirect callback logic and would reduce some queries. The (workspace) mm tests should be complete enough now to verify if a change like that would do.

Member TYPO3\CMS\Core\Database\Schema\Comparator::compareSchemas (Schema $fromSchema, Schema $toSchema)

‪Create PR for doctrine/dbal to change to late binding 'new static()', so our override is working correctly and remove this method after min package raise, if PR was accepted and merged. Also remove 'isAutoIncrementSequenceInSchema()'.

Member TYPO3\CMS\Core\Database\Schema\Comparator::isAutoIncrementSequenceInSchema ($schema, $sequence)

‪Remove this method, when 'compareSchemas()' could removed. We needed to borrow this method along with 'compareSchemas()' through missing late-static binding.

Member TYPO3\CMS\Core\Database\Schema\ConnectionMigrator::getDatabasePlatformName (string $tableName)

‪Adopt usages to directly use platform instanceof checks and remove this method.

Member TYPO3\CMS\Core\Database\Schema\DefaultTcaSchema::getTableFirstPosition (array $tables, string $tableName)

‪It would be better if the incoming $tables structure would be cleaned to contain a table only once before this class is entered.

Member TYPO3\CMS\Core\Database\Schema\SchemaManager\MySQLSchemaManager::_getPortableTableColumnDefinition ($tableColumn)

‪Add array type to $tableColumn argument with doctrine/dbal 4.0 upgrade.

Member TYPO3\CMS\Core\Database\Schema\SchemaManager\MySQLSchemaManager::customGetPortableTableIndexesList (tableIndexesList:$tableIndexesList, tableIndexes:$tableIndexes, tableName:$tableName, connection:$this->_conn,)

‪Change signature to (array $tableIndexes, string $tableName) with doctrine/dbal 4.0

Member TYPO3\CMS\Core\Database\Schema\SchemaManager\MySQLSchemaManager::getDatabasePlatform ()

‪Migrate usage of this and remove this. Will be removed with doctrine/dbal 4.0.

Member TYPO3\CMS\Core\Database\Schema\SchemaManager\OracleSchemaManager::_getPortableTableColumnDefinition ($tableColumn)

‪Add array type to $tableColumn argument with doctrine/dbal 4.0 upgrade.

Member TYPO3\CMS\Core\Database\Schema\SchemaManager\OracleSchemaManager::getDatabasePlatform ()

‪Migrate usage of this and remove this. Will be removed with doctrine/dbal 4.0.

Member TYPO3\CMS\Core\Database\Schema\SchemaManager\PostgreSQLSchemaManager::_getPortableTableColumnDefinition ($tableColumn)

‪Add array type to $tableColumn argument with doctrine/dbal 4.0 upgrade.

Member TYPO3\CMS\Core\Database\Schema\SchemaManager\PostgreSQLSchemaManager::getDatabasePlatform ()

‪Migrate usage of this and remove this. Will be removed with doctrine/dbal 4.0.

Class TYPO3\CMS\Backend\Form\NodeFactory

‪: Declare final in v13. May require adding an interface to allow mocking in tests

Member TYPO3\CMS\Backend\Controller\FormInlineAjaxController::compileChild (ServerRequestInterface $request, array $parentData, $parentFieldName, $childUid, array $inlineStructure)

: This clones methods compileChild from TcaInline Provider. Find a better abstraction

: to also encapsulate the more complex scenarios with combination child and friends.

Member TYPO3\CMS\Backend\Controller\FormSlugAjaxController::suggestAction (ServerRequestInterface $request)

‪)

‪Show a message that the old URL will stop working (possibly add a redirect via checkbox)
‪If the page has subpages, show a warning that the subpages WILL NOT BE MODIFIED and keep the OLD url

Member TYPO3\CMS\Backend\Controller\LoginController::$request

‪: Only set for getCurrentRequest(). Should vanish.

Member TYPO3\CMS\Backend\Controller\LoginController::getLoginProviderIdentifier ()

‪: Ugly. This can be used by login providers, they receive an instance of $this. Unused in core, though. It should vanish when login providers receive love.

Member TYPO3\CMS\Backend\Controller\LoginController::getCurrentRequest ()

‪: Ugly. This can be used by login providers, they receive an instance of $this.

Member TYPO3\CMS\Backend\Controller\SiteInlineAjaxController::compileChild (ServerRequestInterface $request, array $parentData, string $parentFieldName, int $childUid, array $inlineStructure)

: This clones methods compileChild from TcaInline Provider. Find a better abstraction

: to also encapsulate the more complex scenarios with combination child and friends.

Class TYPO3\CMS\Backend\Form\FormDataProvider\ReturnUrl

‪: We may want to get rid of this eventually: The returnUrl should typically be set by calling controllers as initial data, since only controllers know details about current context. The fallback below is a bit of guesswork.

Member TYPO3\CMS\Backend\Form\FormDataProvider\SiteTcaInline::addInlineFirstPid (array $result)

‪: Find out when and if this is different from 'effectivePid'

Member TYPO3\CMS\Backend\Form\FormDataProvider\TcaInline::addInlineFirstPid (array $result)

‪: Find out when and if this is different from 'effectivePid'

Member TYPO3\CMS\Backend\Form\FormDataProvider\TcaInline::resolveConnectedRecordUids (array $parentConfig, $parentTableName, $parentUid, $parentFieldValue)

‪: Cover with unit tests

Member TYPO3\CMS\Backend\Form\FormDataProvider\TcaInline::getLiveDefaultId ($tableName, $uid)

‪: the workspace mess still must be resolved somehow

Member TYPO3\CMS\Backend\Form\FormDataProvider\TcaTypesShowitem::removeFieldsFromPalettes (array $result, $removeListArray)

‪: unit tests!

Member TYPO3\CMS\Backend\Form\InlineStackProcessor::setAjaxConfiguration (array $config)

‪: Review this construct - Why can't the ajax call fetch these data on its own and transfers it to client instead?

Member TYPO3\CMS\Core\Database\Schema\SchemaManager\SQLiteSchemaManager::_getPortableTableColumnDefinition ($tableColumn)

‪Add array type to $tableColumn argument with doctrine/dbal 4.0 upgrade.

Member TYPO3\CMS\Backend\Form\NodeInterface::render ()

‪: Declare most (if not all) implementing non-abstract core classes final in v13.

Class TYPO3\CMS\Backend\Form\Processor\SelectItemProcessor

‪Move additional shareable code from form-engine into here.

Class TYPO3\CMS\Backend\Form\Utility\FormEngineUtility

‪: These helpers are target to be dropped if further FormEngine refactoring is done

Member TYPO3\CMS\Backend\RecordList\Event\ModifyRecordListHeaderColumnsEvent::getRecordList ()

‪Might be replaced by a DTO in the future

Member TYPO3\CMS\Backend\RecordList\Event\ModifyRecordListRecordActionsEvent::getRecordList ()

‪Might be replaced by a DTO in the future

Member TYPO3\CMS\Backend\RecordList\Event\ModifyRecordListTableActionsEvent::getRecordList ()

‪Might be replaced by a DTO in the future

Member TYPO3\CMS\Backend\Tree\TreeNodeCollection::asort (int $flags=SORT_REGULAR)

‪Use return type "true" instead of bool if PHP8.3+ is minimum supported and remove #[\ReturnTypeWillChange].

Member TYPO3\CMS\Backend\View\BackendLayoutView::addBackendLayoutItems (array &$parameters)

‪This method should return the items array instead of using the whole parameters array as reference. This has to be adjusted, as soon as the itemsProcFunc functionality is changed in this regard.

Member TYPO3\CMS\Beuser\Domain\Model\FileMount::getStorage ()

‪This should be part of the ORM not the model class

Member TYPO3\CMS\Core\Authentication\AbstractUserAuthentication::appendCookieToResponse (ResponseInterface $response, ?NormalizedParams $normalizedParams=null)

‪: should go into a middleware?

Member TYPO3\CMS\Core\Authentication\BackendUserAuthentication::$userTSUpdated

‪: Should vanish, see todo below.

Member TYPO3\CMS\Core\Authentication\BackendUserAuthentication::backendCheckLogin (ServerRequestInterface $request=null)

‪deprecate

Member TYPO3\CMS\Core\Resource\InaccessibleFolder::copyTo (Folder $targetFolder, $targetFolderName=null, $conflictMode=DuplicationBehavior::RENAME)

‪change $conflictMode parameter type to DuplicationBehavior in TYPO3 v14.0

Member TYPO3\CMS\Core\Resource\AbstractFile::moveTo (Folder $targetFolder, $targetFileName=null, $conflictMode=DuplicationBehavior::RENAME)

‪change $conflictMode parameter type to DuplicationBehavior in TYPO3 v14.0

Member TYPO3\CMS\Core\Resource\Driver\AbstractDriver::$supportedHashAlgorithms

‪: Remove this from this class. Properties of abstract classes MUST NOT be api. If all drivers need to implement this, consider creating a new method stub in the DriverInterface or consider creating a new SupportedHashAlgorithmsAwareInterface that demands implementations to provide said information. Inside this abstract class, this property is useless, however.

Member TYPO3\CMS\Core\Resource\FileReference::getTitle ()

‪Possibly move this to the image domain object instead

Member TYPO3\CMS\Core\Resource\FileReference::getAlternative ()

‪Possibly move this to the image domain object instead

Member TYPO3\CMS\Core\Resource\FileReference::getDescription ()

‪Possibly move this to the image domain object instead

Member TYPO3\CMS\Core\Resource\FileReference::getLink ()

‪Move this to the image domain object instead

Member TYPO3\CMS\Core\Resource\FileReference::rename (string $newName, $conflictMode=DuplicationBehavior::RENAME)

‪change $conflictMode parameter type to DuplicationBehavior in TYPO3 v14.0

Member TYPO3\CMS\Core\Resource\Folder::addFile ($localFilePath, $fileName=null, $conflictMode=DuplicationBehavior::CANCEL)

‪change $conflictMode parameter type to DuplicationBehavior in TYPO3 v14.0

Member TYPO3\CMS\Core\Resource\Folder::addUploadedFile (array $uploadedFileData, $conflictMode=DuplicationBehavior::CANCEL)

‪change $conflictMode parameter type to DuplicationBehavior in TYPO3 v14.0

Member TYPO3\CMS\Core\Resource\Folder::copyTo (Folder $targetFolder, $targetFolderName=null, $conflictMode=DuplicationBehavior::RENAME)

‪change $conflictMode parameter type to DuplicationBehavior in TYPO3 v14.0

Member TYPO3\CMS\Core\Resource\Folder::moveTo (Folder $targetFolder, $targetFolderName=null, $conflictMode=DuplicationBehavior::RENAME)

‪change $conflictMode parameter type to DuplicationBehavior in TYPO3 v14.0

Member TYPO3\CMS\Core\Resource\InaccessibleFolder::addFile ($localFilePath, $fileName=null, $conflictMode=DuplicationBehavior::CANCEL)

‪change $conflictMode parameter type to DuplicationBehavior in TYPO3 v14.0

Member TYPO3\CMS\Core\Resource\InaccessibleFolder::addUploadedFile (array $uploadedFileData, $conflictMode=DuplicationBehavior::CANCEL)

‪change $conflictMode parameter type to DuplicationBehavior in TYPO3 v14.0

Member TYPO3\CMS\Core\Resource\AbstractFile::copyTo (Folder $targetFolder, $targetFileName=null, $conflictMode=DuplicationBehavior::RENAME)

‪change $conflictMode parameter type to DuplicationBehavior in TYPO3 v14.0

Member TYPO3\CMS\Core\Resource\ProcessedFileRepository::prepareTaskObject (FileInterface $fileObject, string $taskType, array $configuration)

‪: This should be shifted into a TaskFactory or the TaskRegistry

Member TYPO3\CMS\Core\Resource\Processing\LocalPreviewHelper::$defaultConfiguration

‪once preProcessConfiguration() is not needed anymore (or the whole class), this property can be removed

Member TYPO3\CMS\Core\Resource\Processing\LocalPreviewHelper::preProcessConfiguration (array $configuration)

‪This method is not needed anymore and will be deprecated (once the whole class can be removed)

Member TYPO3\CMS\Core\Resource\Processing\TaskInterface::fileNeedsProcessing ()

‪isOutdated()/needsReprocessing()?

Member TYPO3\CMS\Core\Resource\ResourceStorage::addFile ($localFilePath, Folder $targetFolder, $targetFileName='', $conflictMode=DuplicationBehavior::RENAME, $removeOriginal=true)

‪change $conflictMode parameter type to DuplicationBehavior in TYPO3 v14.0

Member TYPO3\CMS\Core\Resource\ResourceStorage::copyFile (FileInterface $file, Folder $targetFolder, $targetFileName=null, $conflictMode=DuplicationBehavior::RENAME)

‪change $conflictMode parameter type to DuplicationBehavior in TYPO3 v14.0

Member TYPO3\CMS\Core\Resource\ResourceStorage::moveFile ($file, $targetFolder, $targetFileName=null, $conflictMode=DuplicationBehavior::RENAME)

‪change $conflictMode parameter type to DuplicationBehavior in TYPO3 v14.0

Member TYPO3\CMS\Core\Resource\ResourceStorage::renameFile ($file, $targetFileName, $conflictMode=DuplicationBehavior::RENAME)

‪change $conflictMode parameter type to DuplicationBehavior in TYPO3 v14.0

Member TYPO3\CMS\Core\Resource\ResourceStorage::addUploadedFile (array|UploadedFile $uploadedFileData, Folder $targetFolder=null, $targetFileName=null, $conflictMode=DuplicationBehavior::CANCEL)

‪change $conflictMode parameter type to DuplicationBehavior in TYPO3 v14.0

Member TYPO3\CMS\Core\Resource\ResourceStorage::getAllFileObjectsInFolder (Folder $folder)

‪check if this is a duplicate

Member TYPO3\CMS\Core\Resource\ResourceStorage::moveFolder (Folder $folderToMove, Folder $targetParentFolder, $newFolderName=null, $conflictMode=DuplicationBehavior::RENAME)

‪change $conflictMode parameter type to DuplicationBehavior in TYPO3 v14.0

Member TYPO3\CMS\Core\Resource\ResourceStorage::copyFolder (FolderInterface $folderToCopy, FolderInterface $targetParentFolder, $newFolderName=null, $conflictMode=DuplicationBehavior::RENAME)

‪change $conflictMode parameter type to DuplicationBehavior in TYPO3 v14.0

Member TYPO3\CMS\Core\Http\Message::validateHeaderName (string $name)

‪: Review. Should be protected / private, maybe align with zend-diactoros again

Member TYPO3\CMS\Core\Database\Schema\SchemaManager\SQLiteSchemaManager::getDatabasePlatform ()

‪Migrate usage of this and remove this. Will be removed with doctrine/dbal 4.0.

Member TYPO3\CMS\Core\Database\Schema\Types\EnumType::getName ()

‪Remove this method with doctrine/dbal 4.0 upgrade.

Member TYPO3\CMS\Core\Database\Schema\Types\SetType::getName ()

‪Remove this method with doctrine/dbal 4.0 upgrade.

Member TYPO3\CMS\Core\DataHandling\DataHandler::sortAndDeleteFlexSectionContainerElements (array $valueArray, array $dataStructure)

‪: It would be better if the magic _ACTION key would be a 'command array', not part of 'data array'

Member TYPO3\CMS\Core\DataHandling\DataHandler::getUnique ($table, $field, $value, $id, $newPid=0)

‪: consider workspaces, especially when publishing a unique value which has a unique value already in live

Member TYPO3\CMS\Core\DataHandling\DataHandler::validateValueForRequired (array $tcaFieldConfig, mixed $value)

‪: If this requirement is not fulfilled, DataHandler should not execute any write statements, which could be properly covered by tests then

Member TYPO3\CMS\Core\DataHandling\DataHandler::undeleteRecordRelations (string $table, int $uid, array $record)

‪: Add functional test undelete coverage to verify details, some details seem to be missing.

Class TYPO3\CMS\Core\DataHandling\Model\CorrelationId

‪Check internal state during v10 development

Member TYPO3\CMS\Core\Domain\Repository\PageRepository::addMountPointParameterToPage (array $page)

‪Find a better name. The current doesn't hit the point.

Member TYPO3\CMS\Core\ExpressionLanguage\RequestWrapper::getSite ()

‪: Could be removed since 'site' variable is provided explicitly.

Member TYPO3\CMS\Core\ExpressionLanguage\RequestWrapper::getSiteLanguage ()

‪: Could be removed since 'siteLanguage' variable is provided explicitly.

Member TYPO3\CMS\Core\Hooks\TcaItemsProcessorFunctions::getRegisteredFlexForms (string $table)

: This approach is limited and doesn't find everything. It works for casual tt_content plugins, though:

: The data structure identifier determination depends on data row, but we don't have all rows at hand here.

: The code thus "guesses" some standard data structure identifier scenarios and tries to resolve those.

: This guessing can not be solved in a good way. A general registry of "all" possible data structures is

: probably not wanted, since that wouldn't work for truly dynamic DS calculations. Probably the only

: thing we could do here is a hook to allow extensions declaring specific data structures to

: allow backend admins to set exclude flags for certain fields in those cases.

Member TYPO3\CMS\Core\Http\Message::filter (string $value)

‪: Unused? And why is this public? Maybe align with zend-diactoros again

Class TYPO3\CMS\Backend\CodeEditor\CodeEditor

‪: refactor to use DI

Member TYPO3\CMS\Core\Http\Message::isValidHeaderValue (string $value)

‪: Review. Should be protected / private, maybe align with zend-diactoros again

Member TYPO3\CMS\Core\Http\Request::$uri

‪It is a PSR-7 spec violation for this to be null. This should be corrected.

Member TYPO3\CMS\Core\Imaging\Icon::setSize (string|IconSize $size)