DataHandlerTest.php

Go to the documentation of this file.

<?php
namespace TYPO3\CMS\Core\Tests\Unit\DataHandler;

use TYPO3\CMS\Core\DataHandling\DataHandler;
use TYPO3\CMS\Core\Tests\AccessibleObjectInterface;

class DataHandlerTest extends \TYPO3\CMS\Core\Tests\UnitTestCase {

    protected $singletonInstances = array();

    protected $subject;

    protected $backEndUser;

    protected $mockDatabaseConnection;

    public function setUp() {
        $GLOBALS['TCA'] = array();
        $this->singletonInstances = \TYPO3\CMS\Core\Utility\GeneralUtility::getSingletonInstances();
        $this->backEndUser = $this->getMock('TYPO3\\CMS\\Core\\Authentication\\BackendUserAuthentication');
        $this->mockDatabaseConnection = $this->getMock('TYPO3\\CMS\\Core\\Database\\DatabaseConnection', array(), array(), '', FALSE);
        $GLOBALS['TYPO3_DB'] = $this->mockDatabaseConnection;
        $this->subject = new \TYPO3\CMS\Core\DataHandling\DataHandler();
        $this->subject->start(array(), '', $this->backEndUser);
    }

    public function tearDown() {
        \TYPO3\CMS\Core\Utility\GeneralUtility::resetSingletonInstances($this->singletonInstances);
        parent::tearDown();
    }

    // Tests for the basic functionality

    public function fixtureCanBeCreated() {
        $this->assertTrue($this->subject instanceof \TYPO3\CMS\Core\DataHandling\DataHandler);
    }

    // Test concerning checkModifyAccessList

    public function adminIsAllowedToModifyNonAdminTable() {
        $this->subject->admin = TRUE;
        $this->assertTrue($this->subject->checkModifyAccessList('tt_content'));
    }

    public function nonAdminIsNorAllowedToModifyNonAdminTable() {
        $this->subject->admin = FALSE;
        $this->assertFalse($this->subject->checkModifyAccessList('tt_content'));
    }

    public function nonAdminWithTableModifyAccessIsAllowedToModifyNonAdminTable() {
        $this->subject->admin = FALSE;
        $this->backEndUser->groupData['tables_modify'] = 'tt_content';
        $this->assertTrue($this->subject->checkModifyAccessList('tt_content'));
    }

    public function adminIsAllowedToModifyAdminTable() {
        $this->subject->admin = TRUE;
        $this->assertTrue($this->subject->checkModifyAccessList('be_users'));
    }

    public function nonAdminIsNotAllowedToModifyAdminTable() {
        $this->subject->admin = FALSE;
        $this->assertFalse($this->subject->checkModifyAccessList('be_users'));
    }

    public function nonAdminWithTableModifyAccessIsNotAllowedToModifyAdminTable() {
        $tableName = $this->getUniqueId('aTable');
        $GLOBALS['TCA'] = array(
            $tableName => array(
                'ctrl' => array(
                    'adminOnly' => TRUE,
                ),
            ),
        );
        $this->subject->admin = FALSE;
        $this->backEndUser->groupData['tables_modify'] = $tableName;
        $this->assertFalse($this->subject->checkModifyAccessList($tableName));
    }

    public function evalCheckValueDouble2() {
        $testData = array(
            '-0,5' => '-0.50',
            '1000' => '1000.00',
            '1000,10' => '1000.10',
            '1000,0' => '1000.00',
            '600.000.000,00' => '600000000.00',
            '60aaa00' => '6000.00'
        );
        foreach ($testData as $value => $expectedReturnValue) {
            $returnValue = $this->subject->checkValue_input_Eval($value, array('double2'), '');
            $this->assertSame($returnValue['value'], $expectedReturnValue);
        }
    }

    public function inputValuesStringsDataProvider() {
        return array(
            '"0" returns zero as integer' => array(
                '0',
                0
            ),
            '"-1999999" is interpreted correctly as -1999999 and is lot lower then -200000' => array(
                '-1999999',
                -1999999
            ),
            '"3000000" is interpreted correctly as 3000000 but is higher then 200000 and set to 200000' => array(
                '3000000',
                2000000
            ),
        );
    }

    public function inputValueCheckRecognizesStringValuesAsIntegerValuesCorrectly($value, $expectedReturnValue) {
        $GLOBALS['TYPO3_DB'] = $this->getMock('TYPO3\\CMS\\Core\\Database\\DatabaseConnection', array(), array(), '', FALSE);
        $tcaFieldConf = array(
            'input' => array(),
            'eval' => 'int',
            'range' => array(
                'lower' => '-2000000',
                'upper' => '2000000'
            )
        );
        $returnValue = $this->subject->checkValue_input(array(), $value, $tcaFieldConf, array());
        $this->assertSame($returnValue['value'], $expectedReturnValue);
    }

    public function inputValueCheckCallsGetDateTimeFormatsForDatetimeFieldsDataProvider() {
        return array(
            'dbType = date' => array(
                'date'
            ),
            'dbType = datetime' => array(
                'datetime'
            )
        );
    }

    public function inputValueCheckCallsNotGetDateTimeFormatsForDatetimeFieldsWithEmptyValue($dbType) {
        $tcaFieldConf = array(
            'input' => array(),
            'dbType' => $dbType
        );
        $this->mockDatabaseConnection->expects($this->never())->method('getDateTimeFormats');
        $this->subject->checkValue_input(array(), '', $tcaFieldConf, array());
    }

    public function inputValueCheckCallsGetDateTimeFormatsForDatetimeFieldsWithNonEmptyValue($dbType) {
        $dateTimeFormats = array(
            'date' => array(
                'empty' => '0000-00-00',
                'format' => 'Y-m-d'
            ),
            'datetime' => array(
                'empty' => '0000-00-00 00:00:00',
                'format' => 'Y-m-d H:i:s'
            )
        );
        $tcaFieldConf = array(
            'input' => array(),
            'dbType' => $dbType
        );
        $this->mockDatabaseConnection->expects($this->once())->method('getDateTimeFormats')->willReturn($dateTimeFormats);
        $this->subject->checkValue_input(array(), $dateTimeFormats[$dbType]['empty'], $tcaFieldConf, '', 0, '');
    }

    public function inputValueCheckDoesNotCallGetDateTimeFormatsForNonDatetimeFieldsDataProvider() {
        return array(
            'tca without dbType' => array(
                array(
                    'input' => array()
                )
            ),
            'tca with dbType != date/datetime' => array(
                array(
                    'input' => array(),
                    'dbType' => 'foo'
                )
            )
        );
    }

    public function inputValueCheckDoesNotCallGetDateTimeFormatsForNonDatetimeFields($tcaFieldConf) {
        $this->mockDatabaseConnection->expects($this->never())->method('getDateTimeFormats');
        $this->subject->checkValue_input(array(), '', $tcaFieldConf, array());
    }


    // Tests concerning checkModifyAccessList
    //
    public function doesCheckModifyAccessListThrowExceptionOnWrongHookInterface() {
        $hookClass = $this->getUniqueId('tx_coretest');
        eval('class ' . $hookClass . ' {}');
        $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_tcemain.php']['checkModifyAccessList'][] = $hookClass;
        $this->subject->checkModifyAccessList('tt_content');
    }

    public function doesCheckModifyAccessListHookGetsCalled() {
        $hookClass = $this->getUniqueId('tx_coretest');
        $hookMock = $this->getMock('TYPO3\\CMS\\Core\\DataHandling\\DataHandlerCheckModifyAccessListHookInterface', array('checkModifyAccessList'), array(), $hookClass);
        $hookMock->expects($this->once())->method('checkModifyAccessList');
        $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_tcemain.php']['checkModifyAccessList'][] = $hookClass;
        $GLOBALS['T3_VAR']['getUserObj'][$hookClass] = $hookMock;
        $this->subject->checkModifyAccessList('tt_content');
    }

    public function doesCheckModifyAccessListHookModifyAccessAllowed() {
        $hookClass = $this->getUniqueId('tx_coretest');
        eval('
            class ' . $hookClass . ' implements \\TYPO3\\CMS\\Core\\DataHandling\\DataHandlerCheckModifyAccessListHookInterface {
                public function checkModifyAccessList(&$accessAllowed, $table, \\TYPO3\\CMS\\Core\\DataHandling\\DataHandler $parent) { $accessAllowed = TRUE; }
            }
        ');
        $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_tcemain.php']['checkModifyAccessList'][] = $hookClass;
        $this->assertTrue($this->subject->checkModifyAccessList('tt_content'));
    }

    // Tests concerning process_datamap

    public function processDatamapForFrozenNonZeroWorkspaceReturnsFalse() {
        $fixture = $this->getMock('TYPO3\\CMS\\Core\\DataHandling\\DataHandler', array('newlog'));
        $this->backEndUser->workspace = 1;
        $this->backEndUser->workspaceRec = array('freeze' => TRUE);
        $fixture->BE_USER = $this->backEndUser;
        $this->assertFalse($fixture->process_datamap());
    }

    public function processDatamapWhenEditingRecordInWorkspaceCreatesNewRecordInWorkspace() {
        // Unset possible hooks on method under test
        // @TODO: Can be removed if unit test boostrap is fixed to not load LocalConfiguration anymore
        $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_tcemain.php']['processDatamapClass'] = array();

        $GLOBALS['TYPO3_DB'] = $this->getMock('TYPO3\\CMS\\Core\\Database\\DatabaseConnection');

        $GLOBALS['TCA'] = array(
            'pages' => array(
                'columns' => array(),
            ),
        );

        $subject = $this->getMock(
            'TYPO3\\CMS\\Core\\DataHandling\\DataHandler',
            array('newlog', 'checkModifyAccessList', 'tableReadOnly', 'checkRecordUpdateAccess')
        );
        $subject->bypassWorkspaceRestrictions = FALSE;
        $subject->datamap = array(
            'pages' => array(
                '1' => array(
                    'header' => 'demo'
                )
            )
        );
        $subject->expects($this->once())->method('checkModifyAccessList')->with('pages')->will($this->returnValue(TRUE));
        $subject->expects($this->once())->method('tableReadOnly')->with('pages')->will($this->returnValue(FALSE));
        $subject->expects($this->once())->method('checkRecordUpdateAccess')->will($this->returnValue(TRUE));
        $backEndUser = $this->getMock('TYPO3\\CMS\\Core\\Authentication\\BackendUserAuthentication');
        $backEndUser->workspace = 1;
        $backEndUser->workspaceRec = array('freeze' => FALSE);
        $backEndUser->expects($this->once())->method('workspaceAllowAutoCreation')->will($this->returnValue(TRUE));
        $backEndUser->expects($this->once())->method('workspaceCannotEditRecord')->will($this->returnValue(TRUE));
        $backEndUser->expects($this->once())->method('recordEditAccessInternals')->with('pages', 1)->will($this->returnValue(TRUE));
        $subject->BE_USER = $backEndUser;
        $createdTceMain = $this->getMock('TYPO3\\CMS\\Core\\DataHandling\\DataHandler', array());
        $createdTceMain->expects($this->once())->method('start')->with(array(), array(
            'pages' => array(
                1 => array(
                    'version' => array(
                        'action' => 'new',
                        'treeLevels' => -1,
                        'label' => 'Auto-created for WS #1'
                    )
                )
            )
        ));
        $createdTceMain->expects($this->never())->method('process_datamap');
        $createdTceMain->expects($this->once())->method('process_cmdmap');
        \TYPO3\CMS\Core\Utility\GeneralUtility::addInstance('TYPO3\\CMS\\Core\\DataHandling\\DataHandler', $createdTceMain);
        $subject->process_datamap();
    }

    public function doesCheckFlexFormValueHookGetsCalled() {
        $GLOBALS['TYPO3_DB'] = $this->getMock('TYPO3\\CMS\\Core\\Database\\DatabaseConnection', array(), array(), '', FALSE);
        $hookClass = $this->getUniqueId('tx_coretest');
        $hookMock = $this->getMock($hookClass, array('checkFlexFormValue_beforeMerge'));
        $hookMock->expects($this->once())->method('checkFlexFormValue_beforeMerge');
        $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_tcemain.php']['checkFlexFormValue'][] = $hookClass;
        $GLOBALS['T3_VAR']['getUserObj'][$hookClass] = $hookMock;
        $this->subject->checkValue_flex(array(), array(), array(), array(), array(), '');
    }

    // Tests concerning log

    public function logCallsWriteLogOfBackendUserIfLoggingIsEnabled() {
        $backendUser = $this->getMock('TYPO3\\CMS\\Core\\Authentication\\BackendUserAuthentication');
        $backendUser->expects($this->once())->method('writelog');
        $this->subject->enableLogging = TRUE;
        $this->subject->BE_USER = $backendUser;
        $this->subject->log('', 23, 0, 42, 0, 'details');
    }

    public function logDoesNotCallWriteLogOfBackendUserIfLoggingIsDisabled() {
        $backendUser = $this->getMock('TYPO3\\CMS\\Core\\Authentication\\BackendUserAuthentication');
        $backendUser->expects($this->never())->method('writelog');
        $this->subject->enableLogging = FALSE;
        $this->subject->BE_USER = $backendUser;
        $this->subject->log('', 23, 0, 42, 0, 'details');
    }

    public function logAddsEntryToLocalErrorLogArray() {
        $backendUser = $this->getMock('TYPO3\\CMS\\Core\\Authentication\\BackendUserAuthentication');
        $this->subject->BE_USER = $backendUser;
        $this->subject->enableLogging = TRUE;
        $this->subject->errorLog = array();
        $logDetailsUnique = $this->getUniqueId('details');
        $this->subject->log('', 23, 0, 42, 1, $logDetailsUnique);
        $this->assertStringEndsWith($logDetailsUnique, $this->subject->errorLog[0]);
    }

    public function logFormatsDetailMessageWithAdditionalDataInLocalErrorArray() {
        $backendUser = $this->getMock('TYPO3\\CMS\\Core\\Authentication\\BackendUserAuthentication');
        $this->subject->BE_USER = $backendUser;
        $this->subject->enableLogging = TRUE;
        $this->subject->errorLog = array();
        $logDetails = $this->getUniqueId('details');
        $this->subject->log('', 23, 0, 42, 1, '%1$s' . $logDetails . '%2$s', -1, array('foo', 'bar'));
        $expected = 'foo' . $logDetails . 'bar';
        $this->assertStringEndsWith($expected, $this->subject->errorLog[0]);
    }

    public function equalSubmittedAndStoredValuesAreDetermined($expected, $submittedValue, $storedValue, $storedType, $allowNull) {
        $result = $this->callInaccessibleMethod(
            $this->subject,
            'isSubmittedValueEqualToStoredValue',
            $submittedValue, $storedValue, $storedType, $allowNull
        );
        $this->assertEquals($expected, $result);
    }

    public function equalSubmittedAndStoredValuesAreDeterminedDataProvider() {
        return array(
            // String
            'string value "" vs. ""' => array(
                TRUE,
                '', '', 'string', FALSE
            ),
            'string value 0 vs. "0"' => array(
                TRUE,
                0, '0', 'string', FALSE
            ),
            'string value 1 vs. "1"' => array(
                TRUE,
                1, '1', 'string', FALSE
            ),
            'string value "0" vs. ""' => array(
                FALSE,
                '0', '', 'string', FALSE
            ),
            'string value 0 vs. ""' => array(
                FALSE,
                0, '', 'string', FALSE
            ),
            'string value null vs. ""' => array(
                TRUE,
                NULL, '', 'string', FALSE
            ),
            // Integer
            'integer value 0 vs. 0' => array(
                TRUE,
                0, 0, 'int', FALSE
            ),
            'integer value "0" vs. "0"' => array(
                TRUE,
                '0', '0', 'int', FALSE
            ),
            'integer value 0 vs. "0"' => array(
                TRUE,
                0, '0', 'int', FALSE
            ),
            'integer value "" vs. "0"' => array(
                TRUE,
                '', '0', 'int', FALSE
            ),
            'integer value "" vs. 0' => array(
                TRUE,
                '', 0, 'int', FALSE
            ),
            'integer value "0" vs. 0' => array(
                TRUE,
                '0', 0, 'int', FALSE
            ),
            'integer value 1 vs. 1' => array(
                TRUE,
                1, 1, 'int', FALSE
            ),
            'integer value 1 vs. "1"' => array(
                TRUE,
                1, '1', 'int', FALSE
            ),
            'integer value "1" vs. "1"' => array(
                TRUE,
                '1', '1', 'int', FALSE
            ),
            'integer value "1" vs. 1' => array(
                TRUE,
                '1', 1, 'int', FALSE
            ),
            'integer value "0" vs. "1"' => array(
                FALSE,
                '0', '1', 'int', FALSE
            ),
            // String with allowed NULL values
            'string with allowed null value "" vs. ""' => array(
                TRUE,
                '', '', 'string', TRUE
            ),
            'string with allowed null value 0 vs. "0"' => array(
                TRUE,
                0, '0', 'string', TRUE
            ),
            'string with allowed null value 1 vs. "1"' => array(
                TRUE,
                1, '1', 'string', TRUE
            ),
            'string with allowed null value "0" vs. ""' => array(
                FALSE,
                '0', '', 'string', TRUE
            ),
            'string with allowed null value 0 vs. ""' => array(
                FALSE,
                0, '', 'string', TRUE
            ),
            'string with allowed null value null vs. ""' => array(
                FALSE,
                NULL, '', 'string', TRUE
            ),
            'string with allowed null value "" vs. null' => array(
                FALSE,
                '', NULL, 'string', TRUE
            ),
            'string with allowed null value null vs. null' => array(
                TRUE,
                NULL, NULL, 'string', TRUE
            ),
            // Integer with allowed NULL values
            'integer with allowed null value 0 vs. 0' => array(
                TRUE,
                0, 0, 'int', TRUE
            ),
            'integer with allowed null value "0" vs. "0"' => array(
                TRUE,
                '0', '0', 'int', TRUE
            ),
            'integer with allowed null value 0 vs. "0"' => array(
                TRUE,
                0, '0', 'int', TRUE
            ),
            'integer with allowed null value "" vs. "0"' => array(
                TRUE,
                '', '0', 'int', TRUE
            ),
            'integer with allowed null value "" vs. 0' => array(
                TRUE,
                '', 0, 'int', TRUE
            ),
            'integer with allowed null value "0" vs. 0' => array(
                TRUE,
                '0', 0, 'int', TRUE
            ),
            'integer with allowed null value 1 vs. 1' => array(
                TRUE,
                1, 1, 'int', TRUE
            ),
            'integer with allowed null value "1" vs. "1"' => array(
                TRUE,
                '1', '1', 'int', TRUE
            ),
            'integer with allowed null value "1" vs. 1' => array(
                TRUE,
                '1', 1, 'int', TRUE
            ),
            'integer with allowed null value 1 vs. "1"' => array(
                TRUE,
                1, '1', 'int', TRUE
            ),
            'integer with allowed null value "0" vs. "1"' => array(
                FALSE,
                '0', '1', 'int', TRUE
            ),
            'integer with allowed null value null vs. ""' => array(
                FALSE,
                NULL, '', 'int', TRUE
            ),
            'integer with allowed null value "" vs. null' => array(
                FALSE,
                '', NULL, 'int', TRUE
            ),
            'integer with allowed null value null vs. null' => array(
                TRUE,
                NULL, NULL, 'int', TRUE
            ),
            'integer with allowed null value null vs. "0"' => array(
                FALSE,
                NULL, '0', 'int', TRUE
            ),
            'integer with allowed null value null vs. 0' => array(
                FALSE,
                NULL, 0, 'int', TRUE
            ),
            'integer with allowed null value "0" vs. null' => array(
                FALSE,
                '0', NULL, 'int', TRUE
            ),
        );
    }

    public function getPlaceholderTitleForTableLabelReturnsLabelThatsMatchesLabelFieldConditions($expected, $eval) {
        $table = 'phpunit_dummy';

        $subject = $this->getAccessibleMock(
            'TYPO3\\CMS\\Core\\DataHandling\\DataHandler',
            array('dummy')
        );

        $backendUser = $this->getMock('TYPO3\\CMS\\Core\\Authentication\\BackendUserAuthentication');
        $subject->BE_USER = $backendUser;
        $subject->BE_USER->workspace = 1;

        $GLOBALS['TCA'][$table] = array();
        $GLOBALS['TCA'][$table]['ctrl'] = array('label' => 'dummy');
        $GLOBALS['TCA'][$table]['columns'] = array(
            'dummy' => array(
                'config' => array(
                    'eval' => $eval
                )
            )
        );

        $this->assertEquals($expected, $subject->_call('getPlaceholderTitleForTableLabel', $table));
    }

    public function getPlaceholderTitleForTableLabelReturnsLabelThatsMatchesLabelFieldConditionsDataProvider() {
        return array(
            array(
                0.10,
                'double2'
            ),
            array(
                0,
                'int'
            ),
            array(
                '0',
                'datetime'
            ),
            array(
                '[PLACEHOLDER, WS#1]',
                ''
            )
        );
    }

    public function deletePagesOnRootLevelIsDenied() {
        $dataHandlerMock = $this->getMock('TYPO3\\CMS\\Core\\DataHandling\\DataHandler', array('canDeletePage', 'newlog2'));
        $dataHandlerMock
            ->expects($this->never())
            ->method('canDeletePage');
        $dataHandlerMock
            ->expects($this->once())
            ->method('newlog2')
            ->with('Deleting all pages starting from the root-page is disabled.', 'pages', 0, 0, 2);

        $dataHandlerMock->deletePages(0);
    }

    public function deleteRecord_procBasedOnFieldTypeRespectsEnableCascadingDelete() {
        $table = $this->getUniqueId('foo_');
        $conf = array(
            'type' => 'inline',
            'foreign_table' => $this->getUniqueId('foreign_foo_'),
            'behaviour' => array(
                'enableCascadingDelete' => 0,
            )
        );

        $mockRelationHandler = $this->getMock('TYPO3\\CMS\\Core\\Database\\RelationHandler', array(), array(), '', FALSE);
        $mockRelationHandler->itemArray = array(
            '1' => array('table' => $this->getUniqueId('bar_'), 'id' => 67)
        );

        $mockDataHandler = $this->getAccessibleMock('TYPO3\\CMS\\Core\\DataHandling\\DataHandler', array('getInlineFieldType', 'deleteAction', 'createRelationHandlerInstance'), array(), '', FALSE);
        $mockDataHandler->expects($this->once())->method('getInlineFieldType')->will($this->returnValue('field'));
        $mockDataHandler->expects($this->once())->method('createRelationHandlerInstance')->will($this->returnValue($mockRelationHandler));
        $mockDataHandler->expects($this->never())->method('deleteAction');
        $mockDataHandler->deleteRecord_procBasedOnFieldType($table, 42, 'foo', 'bar', $conf);
    }

    public function checkValue_checkReturnsExpectedValuesDataProvider() {
        return array(
            'None item selected' => array(
                0,
                0
            ),
            'All items selected' => array(
                7,
                7
            ),
            'Item 1 and 2 are selected' => array(
                3,
                3
            ),
            'Value is higher than allowed' => array(
                15,
                7
            ),
            'Negative value' => array(
                -5,
                0
            )
        );
    }

    public function checkValue_checkReturnsExpectedValues($value, $expectedValue) {
        $expectedResult = array(
            'value' => $expectedValue
        );
        $result = array();
        $tcaFieldConfiguration = array(
            'items' => array(
                array('Item 1', 0),
                array('Item 2', 0),
                array('Item 3', 0)
            )
        );
        $this->assertSame($expectedResult, $this->subject->checkValue_check($result, $value, $tcaFieldConfiguration, array()));
    }
}